Checkbox

Merge lp:~roadmr/checkbox/ppa-packaging-plainbox-provider-canonical-certification-update-config-file-environment-case into lp:~checkbox-dev/checkbox/ppa-packaging-plainbox-provider-canonical-certification

  1. ppa-packaging-plainbox-provider-canonical-certification-update-config-file-environment-case
  2. Merge into ppa-packaging-plainbox-pro...
Proposed by Daniel Manrique
Status: Merged
Approved by: Daniel Manrique
Approved revision: 3
Merged at revision: 3
Proposed branch: lp:~roadmr/checkbox/ppa-packaging-plainbox-provider-canonical-certification-update-config-file-environment-case
Merge into: lp:~checkbox-dev/checkbox/ppa-packaging-plainbox-provider-canonical-certification
Diff against target: 21 lines (+6/-6)
1 file modified
debian/extras/canonical-certification-config/canonical-certification.conf (+6/-6)
To merge this branch: bzr merge lp:~roadmr/checkbox/ppa-packaging-plainbox-provider-canonical-certification-update-config-file-environment-case
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Zygmunt Krynicki Pending
Review via email: mp+213278@code.launchpad.net

This proposal supersedes a proposal from 2014-03-28.

Description of the change

Correct case of sample environment variables in config file, to avoid confusion

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote : Posted in a previous version of this proposal

Target branch is wrong

review: Needs Fixing
Revision history for this message
Daniel Manrique (roadmr) wrote :

Fixed target branch, self-approving

review: Approve
Revision history for this message
Daniel Manrique (roadmr) wrote :

Awesome, tarmac doesn't know about this branch...

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

There is no CI on that tree so just push it for now

Sent from my BlackBerry 10 smartphone.
  Original Message
From: Daniel Manrique
Sent: piątek, 28 marca 2014 16:29
To: Daniel Manrique
Reply To: <email address hidden>
Subject: Re: [Merge] lp:~roadmr/checkbox/ppa-packaging-plainbox-provider-canonical-certification-update-config-file-environment-case into lp:~checkbox-dev/checkbox/ppa-packaging-plainbox-provider-canonical-certification

Awesome, tarmac doesn't know about this branch...

--
https://code.launchpad.net/~roadmr/checkbox/ppa-packaging-plainbox-provider-canonical-certification-update-config-file-environment-case/+merge/213278
You are requested to review the proposed merge of lp:~roadmr/checkbox/ppa-packaging-plainbox-provider-canonical-certification-update-config-file-environment-case into lp:~checkbox-dev/checkbox/ppa-packaging-plainbox-provider-canonical-certification.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/extras/canonical-certification-config/canonical-certification.conf'
2--- debian/extras/canonical-certification-config/canonical-certification.conf 2014-03-27 17:34:21 +0000
3+++ debian/extras/canonical-certification-config/canonical-certification.conf 2014-03-28 14:39:18 +0000
4@@ -10,11 +10,11 @@
5 [environment]
6 # For virtualization testing.
7 # Uncomment the following 2 lines and set the proper parameters:
8-#kvm_timeout =
9-#kvm_image =
10+#KVM_TIMEOUT =
11+#KVM_IMAGE =
12 # For network testing.
13 # Uncomment the following 4 lines and set the proper parameters:
14-#test_target_ftp = your-ftp-server.example.com
15-#test_user = anonymous
16-#test_pass =
17-#test_target_iperf = your-iperf-server.example.com
18+#TEST_TARGET_FTP = your-ftp-server.example.com
19+#TEST_USER = anonymous
20+#TEST_PASS =
21+#TEST_TARGET_IPERF = your-iperf-server.example.com

Subscribers

People subscribed via source and target branches