Merge lp:~roadmr/checkbox/pci-sys-id into lp:checkbox

[Daniel Manrique]

providers:checkbox: Add ssid_attachment job

It attaches the PCI subsystem ID, this is to be collected for all
systems though it has special significance to uniquely identify a
specific configuration for some manufacturers only.

Also adds this job to relevant whitelists.

providers:checkbox: Add ssid_attachment job

It attaches the PCI subsystem ID, this is to be collected for all
systems though it has special significance to uniquely identify a
specific configuration for some manufacturers only.

Also adds this job to relevant whitelists.

[Zygmunt Krynicki (zyga)]

I don't quite get the point of this change, can you explain please?

review: Needs Information

[Daniel Manrique (roadmr)]

Sure, I explained this below, and we can certainly change this if another approach would be better. But we do need to collect that information :(

One thing I could change is attaching the whole lspci -x output and doing the processing/heuristics on the server if you think it would make it clearer on the checkbox job side. I realize that just 4 hex digits without any other context is a bit cryptic. Let me know!

[Zygmunt Krynicki (zyga)]

More discussion below.

review: Needs Information

[Daniel Manrique (roadmr)]

OK, I created a more generic pci config data attachment, with the idea of then doing the parsing server-side.

I also noticed that this subsystem ID information is shown in lspci -vvnn (which we already have). Example (Notice that I'm running this on a Dell system, but we expect this to only make sense for HP):

$ lspci -x | awk 'NR==4{print $17 $16}'
060a

lspci -vvnn
00:00.0 Host bridge [0600]: Intel Corporation Haswell-ULT DRAM Controller [8086:0a04] (rev 09)
        Subsystem: Dell Device [1028:060a]
                                     ^^^^ IT'S THIS VALUE WE WANT

        Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
        Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort+ >SERR- <PERR- INTx-
        Latency: 0
        Capabilities: <access denied>

However I hesitate to change the way we're getting it since we got this information from the CE team and I'd prefer not to deviate from their data collection too much.

[lp:~roadmr/checkbox/pci-sys-id]

3728. By Daniel Manrique on 2015-04-28

providers: Add lspci_standard_config_attachment job to pertinent whitelists

3729. By Daniel Manrique on 2015-04-28

providers:checkbox: Add lspci_standard_config_attachment job

It attaches a dump of PCI standard configuration data for all
devices in the system.

This raw data is used to uniquely identify a specific configuration
for some manufacturers only, and may have other uses in the future.

[Zygmunt Krynicki (zyga)]

+1

review: Approve

=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist'
--- providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist	2015-04-27 09:46:56 +0000
+++ providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist	2015-04-28 16:50:48 +0000
@@ -401,6 +401,7 @@
 dmidecode_attachment
 efi_attachment
 lspci_attachment
+lspci_standard_config_attachment
 lsusb_attachment
 kernel_cmdline_attachment
 meminfo_attachment
 
=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist'
--- providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist	2015-04-24 20:58:54 +0000
+++ providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist	2015-04-28 16:50:48 +0000
@@ -349,6 +349,7 @@
 dmidecode_attachment
 efi_attachment
 lspci_attachment
+lspci_standard_config_attachment
 lsusb_attachment
 kernel_cmdline_attachment
 meminfo_attachment
 
=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist'
--- providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist	2015-04-24 20:58:54 +0000
+++ providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist	2015-04-28 16:50:48 +0000
@@ -349,6 +349,7 @@
 dmidecode_attachment
 efi_attachment
 lspci_attachment
+lspci_standard_config_attachment
 lsusb_attachment
 kernel_cmdline_attachment
 meminfo_attachment
 
=== modified file 'providers/plainbox-provider-checkbox/jobs/info.txt.in'
--- providers/plainbox-provider-checkbox/jobs/info.txt.in	2015-04-24 20:27:47 +0000
+++ providers/plainbox-provider-checkbox/jobs/info.txt.in	2015-04-28 16:50:48 +0000
@@ -57,6 +57,15 @@
 estimated_duration: 1.322
 _description: Attaches very verbose lspci output (with central database Query).
 
+id: lspci_standard_config_attachment
+_summary: Attach PCI configuration space hex dump
+plugin: attachment
+command: lspci -x
+estimated_duration: 0.1
+_description:
+    Attaches a hex dump of the standard part of the PCI configuration
+    space for all PCI devices.
+
 id: lsusb_attachment
 plugin: attachment
 requires: package.name == 'usbutils'
 
=== modified file 'providers/plainbox-provider-checkbox/whitelists/autotesting.whitelist'
--- providers/plainbox-provider-checkbox/whitelists/autotesting.whitelist	2014-04-25 22:38:44 +0000
+++ providers/plainbox-provider-checkbox/whitelists/autotesting.whitelist	2015-04-28 16:50:48 +0000
@@ -17,6 +17,7 @@
 dmidecode_attachment
 efi_attachment
 lspci_attachment
+lspci_standard_config_attachment
 meminfo_attachment
 modprobe_attachment
 modules_attachment
 
=== modified file 'providers/plainbox-provider-checkbox/whitelists/hwsubmit.whitelist'
--- providers/plainbox-provider-checkbox/whitelists/hwsubmit.whitelist	2015-04-24 20:58:54 +0000
+++ providers/plainbox-provider-checkbox/whitelists/hwsubmit.whitelist	2015-04-28 16:50:48 +0000
@@ -18,6 +18,7 @@
 kernel_cmdline_attachment
 lsmod_attachment
 lspci_attachment
+lspci_standard_config_attachment
 modprobe_attachment
 modules_attachment
 sysfs_attachment