Merge lp:~roadmr/checkbox/packaging-1194717-add-recommends-audio-test into lp:~checkbox-dev/checkbox/checkbox-packaging

[Daniel Manrique]

This adds some gstreamer1.0 packages as recommends for checkbox, so that they are correctly installed when installing the PPA version of checkbox.

This adds some gstreamer1.0 packages as recommends for checkbox, so that they are correctly installed when installing the PPA version of checkbox.

The implication of this change is that checkbox will be UNINSTALLABLE on Precise *unless* the gstreamer developers PPA is added, since a few of the required gstreamer packages are not in the Precise archive.

For instance, this means that we will have to add the gstreamer PPA to our preseeds to enable checkbox for Precise to be installed during certification and/or SRU testing.

Please be as brutal as you want with this merge request, I'd rather have to rework things than land stuff that will be nonfunctional or make checkbox uninstallable.

[Zygmunt Krynicki (zyga)]

+1

review: Approve

[Zygmunt Krynicki (zyga)]

Actually, thinking about it, do you think we should have:

Recommends: gstreamer-1.0-blarg | gstreamer-0.10-blarg

[Daniel Manrique (roadmr)]

On one hand, the test will simply not work unless gstreamer 1.0 is installed, so I could also just remove all the dependencies for gstreamer 0.10. Downside is that this will, as mentioned, make checkbox entirely uninstallable on Precise without the PPA.

On the other hand, I wonder if it would be worthwhile making it so that, if gstreamer 1.0 is not available, it doesn't get installed, we install gstreamer 0.10 for those tests that work well with either version, and the job's requirements ensure that the test won't run if the requirements are not met.

I could change the recommends/depends so that I list an alternative for every gstreamer-1.0 package. Thus, if 1.0 is available, it will install that; if not, it will fall back to 0.10.

Do you know if the | operator honors order? e.g. if I say "gstreamer-1.0 | gstreamer-0.10" will it prefer 1.0 always?

[Zygmunt Krynicki (zyga)]

yes, it explicitly does ordering that way to make it deterministic

On Thu, Jun 27, 2013 at 5:46 PM, Daniel Manrique <
<email address hidden>> wrote:

> On one hand, the test will simply not work unless gstreamer 1.0 is
> installed, so I could also just remove all the dependencies for gstreamer
> 0.10. Downside is that this will, as mentioned, make checkbox entirely
> uninstallable on Precise without the PPA.
>
> On the other hand, I wonder if it would be worthwhile making it so that,
> if gstreamer 1.0 is not available, it doesn't get installed, we install
> gstreamer 0.10 for those tests that work well with either version, and the
> job's requirements ensure that the test won't run if the requirements are
> not met.
>
> I could change the recommends/depends so that I list an alternative for
> every gstreamer-1.0 package. Thus, if 1.0 is available, it will install
> that; if not, it will fall back to 0.10.
>
> Do you know if the | operator honors order? e.g. if I say "gstreamer-1.0 |
> gstreamer-0.10" will it prefer 1.0 always?
>
> --
>
> https://code.launchpad.net/~roadmr/checkbox/packaging-1194717-add-recommends-audio-test/+merge/171640
> You are reviewing the proposed merge of
> lp:~roadmr/checkbox/packaging-1194717-add-recommends-audio-test into
> lp:~checkbox-dev/checkbox/checkbox-packaging.
>

[lp:~roadmr/checkbox/packaging-1194717-add-recommends-audio-test]

9. By Daniel Manrique on 2013-06-27

Added alternatives for all gstreamer1.0 packages

[Daniel Manrique (roadmr)]

OK, based on that I reordered the dependencies and added gstreamer0.10 equivalents for all the 1.0 packages. The end result is that the package *should* be installable on vanilla Precise, without gstreamer PPA, but the audio test will *not* work, as message handling is very broken on gstreamer 0.10 (this is expressed both in the jobs that use audio_test and in the script itself which will bail if it can't load Gst 1.0). If the PPA is added, then it will give preference to the 1.0 packages and it should work even on Precise.

review: Needs Resubmitting

[Zygmunt Krynicki (zyga)]

+1

review: Approve

[Daniel Manrique (roadmr)]

Merging manually since tarmac doesn't handle this checkbox-packaging branch yet.

[Zygmunt Krynicki (zyga)]

anyone wants to add it to tarmac conifg?

On Fri, Jun 28, 2013 at 12:23 AM, <email address hidden> wrote:

> The proposal to merge
> lp:~roadmr/checkbox/packaging-1194717-add-recommends-audio-test into
> lp:~checkbox-dev/checkbox/checkbox-packaging has been updated.
>
> Status: Approved => Merged
>
> For more details, see:
>
> https://code.launchpad.net/~roadmr/checkbox/packaging-1194717-add-recommends-audio-test/+merge/171640
> --
>
> https://code.launchpad.net/~roadmr/checkbox/packaging-1194717-add-recommends-audio-test/+merge/171640
> You are reviewing the proposed merge of
> lp:~roadmr/checkbox/packaging-1194717-add-recommends-audio-test into
> lp:~checkbox-dev/checkbox/checkbox-packaging.
>

=== modified file 'debian/control'
--- debian/control	2013-06-01 14:18:12 +0000
+++ debian/control	2013-06-27 18:30:34 +0000
@@ -19,7 +19,7 @@
                python3-mock,
                python3-pkg-resources,
                qt4-qmake
-Vcs-Bzr: https://code.launchpad.net/~hardware-certification/checkbox/trunk
+Vcs-Bzr: https://code.launchpad.net/~checkbox-dev/checkbox/trunk
 
 Package: checkbox
 Section: python
@@ -33,8 +33,11 @@
          ${python3:Depends},
          ${shlibs:Depends}
 Recommends: dpkg (>= 1.13),
-            gir1.2-gst-plugins-base-0.10 | gir1.2-gst-plugins-base-1.0,
-            gstreamer0.10-gconf | gstreamer1.0-plugins-good,
+            gir1.2-gst-plugins-base-1.0 | gir1.2-gst-plugins-base-0.10,
+            gir1.2-gstreamer-1.0 | gir1.2-gstreamer-0.10,
+            gstreamer1.0-plugins-good | gstreamer0.10-gconf,
+            gstreamer1.0-pulseaudio | gstreamer0.10-pulseaudio,
+            libgstreamer1.0-0 | libgstreamer0.10-0,
             lsb-release,
             perl,
             pm-utils,