Code review comment for lp:~roadmr/checkbox/lightning

Revision history for this message
Marc Tardif (cr3) wrote :

Very useful, thanks man! Just a couple comments about your code:

1. It is more Pythonish (or Pythonic?) to pass keyword arguments to function without spaces:

  foo(a=1, b=2).

2. In plugins/, you access private variables from the persist object:

  self.persist._backend.safe_file_closing = True

Instead, you might have liked to consider adding a public getter and setter on the Persist class:


However, this doesn't prevent the code from working so I'm merging. All good!

review: Approve

« Back to merge proposal