Code review comment for lp:~roadmr/checkbox/fix-gconf-resource

Revision history for this message
Marc Tardif (cr3) wrote :

Hm, I remember specifically setting the encoding to ascii but I was probably only thinking about the keys. I now see that the values can conceivably be encoded in utf-8!

The changes look good but I made a couple modifications while merging:

1. The parentheses around the check_output were not necessary for the arguments to be split on multiple lines.
2. The length of the command and its arguments was short, so they didn't really need to be split in the first place :)

review: Approve

« Back to merge proposal