Merge lp:~roadmr/checkbox/cmdline_attachment into lp:checkbox

Proposed by Daniel Manrique
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 3722
Merged at revision: 3722
Proposed branch: lp:~roadmr/checkbox/cmdline_attachment
Merge into: lp:checkbox
Diff against target: 73 lines (+11/-0)
6 files modified
providers/plainbox-provider-certification-client/whitelists/client-cert-regression.whitelist (+1/-0)
providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist (+1/-0)
providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist (+1/-0)
providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist (+1/-0)
providers/plainbox-provider-checkbox/jobs/info.txt.in (+6/-0)
providers/plainbox-provider-checkbox/whitelists/hwsubmit.whitelist (+1/-0)
To merge this branch: bzr merge lp:~roadmr/checkbox/cmdline_attachment
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+257437@code.launchpad.net

Commit message

providers:checkbox: Added kernel_cmdline_attachment job.

This shows the parameters used to boot the kernel and may contain information on global kernel parameters, quirks or tweaks used to enable a system.

Description of the change

providers:checkbox: Added kernel_cmdline_attachment job.

This shows the parameters used to boot the kernel and may contain information on global kernel parameters, quirks or tweaks used to enable a system.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I've added two question marks below. If those changes are needed please commit and explain them separately. Thanks

review: Needs Fixing
Revision history for this message
Daniel Manrique (roadmr) wrote :

Oops, I thought I'd removed them. I did so, none of those changes are necessary.

3722. By Daniel Manrique

providers: Added the kernel_cmdline_attachment to whitelists

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-cert-regression.whitelist'
--- providers/plainbox-provider-certification-client/whitelists/client-cert-regression.whitelist 2014-12-11 00:17:49 +0000
+++ providers/plainbox-provider-certification-client/whitelists/client-cert-regression.whitelist 2015-04-24 20:59:18 +0000
@@ -122,6 +122,7 @@
122efi_attachment122efi_attachment
123lspci_attachment123lspci_attachment
124lsusb_attachment124lsusb_attachment
125kernel_cmdline_attachment
125meminfo_attachment126meminfo_attachment
126modprobe_attachment127modprobe_attachment
127modules_attachment128modules_attachment
128129
=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist'
--- providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist 2015-04-16 07:29:03 +0000
+++ providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist 2015-04-24 20:59:18 +0000
@@ -376,6 +376,7 @@
376efi_attachment376efi_attachment
377lspci_attachment377lspci_attachment
378lsusb_attachment378lsusb_attachment
379kernel_cmdline_attachment
379meminfo_attachment380meminfo_attachment
380modprobe_attachment381modprobe_attachment
381modules_attachment382modules_attachment
382383
=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist'
--- providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist 2014-11-27 05:50:48 +0000
+++ providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist 2015-04-24 20:59:18 +0000
@@ -350,6 +350,7 @@
350efi_attachment350efi_attachment
351lspci_attachment351lspci_attachment
352lsusb_attachment352lsusb_attachment
353kernel_cmdline_attachment
353meminfo_attachment354meminfo_attachment
354modprobe_attachment355modprobe_attachment
355modules_attachment356modules_attachment
356357
=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist'
--- providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist 2014-11-27 05:50:48 +0000
+++ providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist 2015-04-24 20:59:18 +0000
@@ -350,6 +350,7 @@
350efi_attachment350efi_attachment
351lspci_attachment351lspci_attachment
352lsusb_attachment352lsusb_attachment
353kernel_cmdline_attachment
353meminfo_attachment354meminfo_attachment
354modprobe_attachment355modprobe_attachment
355modules_attachment356modules_attachment
356357
=== modified file 'providers/plainbox-provider-checkbox/jobs/info.txt.in'
--- providers/plainbox-provider-checkbox/jobs/info.txt.in 2015-01-28 23:18:11 +0000
+++ providers/plainbox-provider-checkbox/jobs/info.txt.in 2015-04-24 20:59:18 +0000
@@ -247,3 +247,9 @@
247estimated_duration: 0.1247estimated_duration: 0.1
248_description: Attaches the debug log from the virtualization run248_description: Attaches the debug log from the virtualization run
249command: [ -f $PLAINBOX_SESSION_SHARE/virt_debug ] && cat $PLAINBOX_SESSION_SHARE/virt_debug249command: [ -f $PLAINBOX_SESSION_SHARE/virt_debug ] && cat $PLAINBOX_SESSION_SHARE/virt_debug
250
251id: kernel_cmdline_attachment
252plugin: attachment
253command: cat /proc/cmdline
254estimated_duration: 0.005
255_description: Attaches the kernel commandline used to boot
250256
=== modified file 'providers/plainbox-provider-checkbox/whitelists/hwsubmit.whitelist'
--- providers/plainbox-provider-checkbox/whitelists/hwsubmit.whitelist 2014-03-20 14:11:44 +0000
+++ providers/plainbox-provider-checkbox/whitelists/hwsubmit.whitelist 2015-04-24 20:59:18 +0000
@@ -15,6 +15,7 @@
15dmesg_attachment15dmesg_attachment
16dmi_attachment16dmi_attachment
17dmidecode_attachment17dmidecode_attachment
18kernel_cmdline_attachment
18lsmod_attachment19lsmod_attachment
19lspci_attachment20lspci_attachment
20modprobe_attachment21modprobe_attachment

Subscribers

People subscribed via source and target branches