Merge lp:~roadmr/checkbox/cmdline_attachment into lp:checkbox

Proposed by Daniel Manrique
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 3722
Merged at revision: 3722
Proposed branch: lp:~roadmr/checkbox/cmdline_attachment
Merge into: lp:checkbox
Diff against target: 73 lines (+11/-0)
6 files modified
providers/plainbox-provider-certification-client/whitelists/client-cert-regression.whitelist (+1/-0)
providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist (+1/-0)
providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist (+1/-0)
providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist (+1/-0)
providers/plainbox-provider-checkbox/jobs/info.txt.in (+6/-0)
providers/plainbox-provider-checkbox/whitelists/hwsubmit.whitelist (+1/-0)
To merge this branch: bzr merge lp:~roadmr/checkbox/cmdline_attachment
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+257437@code.launchpad.net

Commit message

providers:checkbox: Added kernel_cmdline_attachment job.

This shows the parameters used to boot the kernel and may contain information on global kernel parameters, quirks or tweaks used to enable a system.

Description of the change

providers:checkbox: Added kernel_cmdline_attachment job.

This shows the parameters used to boot the kernel and may contain information on global kernel parameters, quirks or tweaks used to enable a system.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I've added two question marks below. If those changes are needed please commit and explain them separately. Thanks

review: Needs Fixing
Revision history for this message
Daniel Manrique (roadmr) wrote :

Oops, I thought I'd removed them. I did so, none of those changes are necessary.

3722. By Daniel Manrique

providers: Added the kernel_cmdline_attachment to whitelists

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-cert-regression.whitelist'
2--- providers/plainbox-provider-certification-client/whitelists/client-cert-regression.whitelist 2014-12-11 00:17:49 +0000
3+++ providers/plainbox-provider-certification-client/whitelists/client-cert-regression.whitelist 2015-04-24 20:59:18 +0000
4@@ -122,6 +122,7 @@
5 efi_attachment
6 lspci_attachment
7 lsusb_attachment
8+kernel_cmdline_attachment
9 meminfo_attachment
10 modprobe_attachment
11 modules_attachment
12
13=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist'
14--- providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist 2015-04-16 07:29:03 +0000
15+++ providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist 2015-04-24 20:59:18 +0000
16@@ -376,6 +376,7 @@
17 efi_attachment
18 lspci_attachment
19 lsusb_attachment
20+kernel_cmdline_attachment
21 meminfo_attachment
22 modprobe_attachment
23 modules_attachment
24
25=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist'
26--- providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist 2014-11-27 05:50:48 +0000
27+++ providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist 2015-04-24 20:59:18 +0000
28@@ -350,6 +350,7 @@
29 efi_attachment
30 lspci_attachment
31 lsusb_attachment
32+kernel_cmdline_attachment
33 meminfo_attachment
34 modprobe_attachment
35 modules_attachment
36
37=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist'
38--- providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist 2014-11-27 05:50:48 +0000
39+++ providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist 2015-04-24 20:59:18 +0000
40@@ -350,6 +350,7 @@
41 efi_attachment
42 lspci_attachment
43 lsusb_attachment
44+kernel_cmdline_attachment
45 meminfo_attachment
46 modprobe_attachment
47 modules_attachment
48
49=== modified file 'providers/plainbox-provider-checkbox/jobs/info.txt.in'
50--- providers/plainbox-provider-checkbox/jobs/info.txt.in 2015-01-28 23:18:11 +0000
51+++ providers/plainbox-provider-checkbox/jobs/info.txt.in 2015-04-24 20:59:18 +0000
52@@ -247,3 +247,9 @@
53 estimated_duration: 0.1
54 _description: Attaches the debug log from the virtualization run
55 command: [ -f $PLAINBOX_SESSION_SHARE/virt_debug ] && cat $PLAINBOX_SESSION_SHARE/virt_debug
56+
57+id: kernel_cmdline_attachment
58+plugin: attachment
59+command: cat /proc/cmdline
60+estimated_duration: 0.005
61+_description: Attaches the kernel commandline used to boot
62
63=== modified file 'providers/plainbox-provider-checkbox/whitelists/hwsubmit.whitelist'
64--- providers/plainbox-provider-checkbox/whitelists/hwsubmit.whitelist 2014-03-20 14:11:44 +0000
65+++ providers/plainbox-provider-checkbox/whitelists/hwsubmit.whitelist 2015-04-24 20:59:18 +0000
66@@ -15,6 +15,7 @@
67 dmesg_attachment
68 dmi_attachment
69 dmidecode_attachment
70+kernel_cmdline_attachment
71 lsmod_attachment
72 lspci_attachment
73 modprobe_attachment

Subscribers

People subscribed via source and target branches