Code review comment for lp:~roadmr/checkbox/checkbox-qt-i18n

Revision history for this message
David Planella (dpm) wrote :

Daniel has asked me to have a look at the merge proposal. While I don't think I'll manage to review in detail today, I can say that reading the MP's description all the high level steps make perfect sense to me.

You might have already addressed this, but it would make sense to make the unity 2d translation wrapper function as much generic as possible, as I could well imagine that future Ubuntu projects will make use of it, and it will be much easier to set up those projects if it can be used in a generic way.

As per Sylvain's comment, the .pot file should be updated every time you do a release, or every time you've got a set of new strings that you think translators can work on.

In terms of the Ubuntu packaging, the package will need to generate the .pot file as part of the build so translations for the source package can be shipped in language packs (have a look at dh_translations and have a chat with pitti if you've got questions on this area).

Good work, non-English users will appreciate it!

« Back to merge proposal