Merge lp:~roadmr/checkbox/1342304-network-bad-strings into lp:checkbox
Status: | Merged |
---|---|
Approved by: | Zygmunt Krynicki |
Approved revision: | 3129 |
Merged at revision: | 3131 |
Proposed branch: | lp:~roadmr/checkbox/1342304-network-bad-strings |
Merge into: | lp:checkbox |
Diff against target: |
154 lines (+42/-49) 1 file modified
providers/plainbox-provider-checkbox/bin/network (+42/-49) |
To merge this branch: | bzr merge lp:~roadmr/checkbox/1342304-network-bad-strings |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zygmunt Krynicki (community) | Approve | ||
Review via email: mp+226922@code.launchpad.net |
Commit message
providers:
- Provide clearer message of where to configure settings.
- Handle "partial" settings (i.e. test won't mysteriously exit if not
all 4 values are provided, even if for the current test they're not
all needed)
- Remove support for the legacy /etc/checkbox.d files.
https:/
https:/
Description of the change
providers:
- Provide clearer message of where to configure settings.
- Handle "partial" settings (i.e. test won't mysteriously exit if not
all 4 values are provided, even if for the current test they're not
all needed)
- Remove support for the legacy /etc/checkbox.d files.
https:/
https:/
Some comments and questions. See below for details.
I haven't tested this but it looks okay-ish except for one question