Merge lp:~roadmr/checkbox/1302851-bad-transport-api-usage into lp:checkbox

[Daniel Manrique]

checkbox-ng:commands:certification: fix Transport API usage

    The transport API was recently refactored, and instantiation and
    invocation of the CertificationTransport in this command wasn't updated
    to account for that. (LP: #1302851)

    checkbox-ng:commands:certification: fix Transport API usage

    The transport API was recently refactored, and instantiation and
    invocation of the CertificationTransport in this command wasn't updated
    to account for that. (LP: #1302851)

[Zygmunt Krynicki (zyga)]

+1

review: Approve

[Daniel Manrique (roadmr)]

Thanks! BTW with this fix applied, c-c-server does correctly test, save reports in html, xml and xlsx formats, and submit results to certification, so end-to-end-run FTW, +1 on the entire stack for c-c-server usage.

review: Approve

=== modified file 'checkbox-ng/checkbox_ng/commands/certification.py'
--- checkbox-ng/checkbox_ng/commands/certification.py	2014-01-29 15:53:59 +0000
+++ checkbox-ng/checkbox_ng/commands/certification.py	2014-04-04 21:49:43 +0000
@@ -80,14 +80,14 @@
         # Create the transport object
         try:
             transport = CertificationTransport(
-                self.config.c3_url, options_string, self.config)
+                self.config.c3_url, options_string)
         except InvalidSecureIDError as exc:
             print(exc)
             return False
         with open(self.submission_file) as stream:
             try:
                 # Send the data, reading from the fallback file
-                result = transport.send(stream)
+                result = transport.send(stream, self.config)
                 if 'url' in result:
                     print("Successfully sent, submission status at {0}".format(
                           result['url']))