Merge lp:~roadmr/checkbox/1183271-missing-plugins-in-potfiles into lp:checkbox

Proposed by Daniel Manrique
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 2143
Merged at revision: 2143
Proposed branch: lp:~roadmr/checkbox/1183271-missing-plugins-in-potfiles
Merge into: lp:checkbox
Diff against target: 33 lines (+5/-0)
2 files modified
debian/changelog (+2/-0)
po/POTFILES.in (+3/-0)
To merge this branch: bzr merge lp:~roadmr/checkbox/1183271-missing-plugins-in-potfiles
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+165422@code.launchpad.net

Commit message

Added some missing plugins to POTFILES.in, so their strings can be translated.

Description of the change

Added some missing plugins to POTFILES.in, so their strings can be translated.

I also took the opportunity to sort the plugin names in POTFILES.in so they look nicer.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

On Thu, May 23, 2013 at 5:35 PM, Daniel Manrique <
<email address hidden>> wrote:

> Daniel Manrique has proposed merging
> lp:~roadmr/checkbox/1183271-missing-plugins-in-potfiles into lp:checkbox.
>
> Commit message:
> Added some missing plugins to POTFILES.in, so their strings can be
> translated.
>
> Requested reviews:
> Checkbox Developers (checkbox-dev)
> Related bugs:
> Bug #1183271 in checkbox: "Checkbox: gksu password prompt not
> translatable"
> https://bugs.launchpad.net/checkbox/+bug/1183271
>
> For more details, see:
>
> https://code.launchpad.net/~roadmr/checkbox/1183271-missing-plugins-in-potfiles/+merge/165422
>
> Added some missing plugins to POTFILES.in, so their strings can be
> translated.
>
> I also took the opportunity to sort the plugin names in POTFILES.in so
> they look nicer.
> --
>
> https://code.launchpad.net/~roadmr/checkbox/1183271-missing-plugins-in-potfiles/+merge/165422
> Your team Checkbox Developers is requested to review the proposed merge of
> lp:~roadmr/checkbox/1183271-missing-plugins-in-potfiles into lp:checkbox.
>
> === modified file 'debian/changelog'
> --- debian/changelog 2013-05-21 15:54:28 +0000
> +++ debian/changelog 2013-05-23 15:34:26 +0000
> @@ -8,6 +8,8 @@
> [ Daniel Manrique ]
> * Expanded optical_drive resource command so it correctly handles
> systems
> with no optical drive (LP: #1182489)
> + * Added missing plugin files to po/POTFILES.in so their strings are
> + translatable (LP: #1183271)
>
> -- Brendan Donegan <email address hidden> Fri, 17 May 2013
> 07:58:29 +0100
>
>
> === modified file 'po/POTFILES.in'
> --- po/POTFILES.in 2013-04-16 16:07:55 +0000
> +++ po/POTFILES.in 2013-05-23 15:34:26 +0000
> @@ -54,13 +54,16 @@
> checkbox_urwid/urwid_interface.py
> checkbox_gtk/gtk_interface.py
> checkbox/user_interface.py
> +plugins/backend_info.py
> plugins/final_prompt.py
> plugins/gather_prompt.py
> plugins/intro_prompt.py
> +plugins/jobs_info.py
> plugins/launchpad_exchange.py
> plugins/launchpad_prompt.py
> plugins/launchpad_report.py
> plugins/lock_prompt.py
> +plugins/message_info.py
> plugins/recover_prompt.py
> plugins/report_prompt.py
> plugins/shell_test.py
>
>
>

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Boo, no automatic approval via email without signing

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-05-21 15:54:28 +0000
3+++ debian/changelog 2013-05-23 15:34:26 +0000
4@@ -8,6 +8,8 @@
5 [ Daniel Manrique ]
6 * Expanded optical_drive resource command so it correctly handles systems
7 with no optical drive (LP: #1182489)
8+ * Added missing plugin files to po/POTFILES.in so their strings are
9+ translatable (LP: #1183271)
10
11 -- Brendan Donegan <brendan.donegan@canonical.com> Fri, 17 May 2013 07:58:29 +0100
12
13
14=== modified file 'po/POTFILES.in'
15--- po/POTFILES.in 2013-04-16 16:07:55 +0000
16+++ po/POTFILES.in 2013-05-23 15:34:26 +0000
17@@ -54,13 +54,16 @@
18 checkbox_urwid/urwid_interface.py
19 checkbox_gtk/gtk_interface.py
20 checkbox/user_interface.py
21+plugins/backend_info.py
22 plugins/final_prompt.py
23 plugins/gather_prompt.py
24 plugins/intro_prompt.py
25+plugins/jobs_info.py
26 plugins/launchpad_exchange.py
27 plugins/launchpad_prompt.py
28 plugins/launchpad_report.py
29 plugins/lock_prompt.py
30+plugins/message_info.py
31 plugins/recover_prompt.py
32 plugins/report_prompt.py
33 plugins/shell_test.py

Subscribers

People subscribed via source and target branches