Merge lp:~roadmr/checkbox-certification/bug1274094 into lp:checkbox-certification

Proposed by Daniel Manrique
Status: Merged
Approved by: Daniel Manrique
Approved revision: 649
Merged at revision: 649
Proposed branch: lp:~roadmr/checkbox-certification/bug1274094
Merge into: lp:checkbox-certification
Diff against target: 28 lines (+4/-2)
2 files modified
debian/changelog (+3/-1)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~roadmr/checkbox-certification/bug1274094
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+221237@code.launchpad.net

Commit message

Remove dependency on checkbox from checkbox-certification-tools (because it doesn't strictly speaking require checkbox to function), but add python3-requests, because it does need that to function.

Description of the change

Remove dependency on checkbox from checkbox-certification-tools (because it doesn't strictly speaking require checkbox to function), but add python3-requests, because it does need that to function.

A resubmit/fix of https://code.launchpad.net/~brendan-donegan/checkbox-certification/bug1274094

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

This is exactly the same code as https://code.launchpad.net/~brendan-donegan/checkbox-certification/bug1274094/+merge/204360 save for the changelog fix, so I'll self-approve since that one was already approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2014-02-14 17:13:06 +0000
+++ debian/changelog 2014-05-28 13:56:54 +0000
@@ -13,8 +13,10 @@
1313
14 [ Brendan Donegan ]14 [ Brendan Donegan ]
1515
16 * Changed python3 to python3-all in Build-Depends. 16 * Changed python3 to python3-all in Build-Depends.
17 * Removed whitelists because they're now in checkbox.17 * Removed whitelists because they're now in checkbox.
18 * Removed dependency on checkbox from checkbox-certification-tools
19 and added a dependency on python3-requests (LP: #1274094)
1820
19 -- Zygmunt Krynicki <zygmunt.krynicki@canonical.com> Fri, 14 Feb 2014 18:04:17 +010021 -- Zygmunt Krynicki <zygmunt.krynicki@canonical.com> Fri, 14 Feb 2014 18:04:17 +0100
2022
2123
=== modified file 'debian/control'
--- debian/control 2014-01-17 16:59:28 +0000
+++ debian/control 2014-05-28 13:56:54 +0000
@@ -55,7 +55,7 @@
55Section: python55Section: python
56Architecture: all56Architecture: all
57Priority: standard57Priority: standard
58Depends: checkbox (>= 0.16~ppa), python3-pkg-resources, ${python3:Depends}58Depends: python3-pkg-resources, python3-requests, ${python3:Depends}
59Description: Checkbox Certification Tools59Description: Checkbox Certification Tools
60 This package contains additional, useful tools to aid in the certification60 This package contains additional, useful tools to aid in the certification
61 process.61 process.

Subscribers

People subscribed via source and target branches