Merge lp:~roadmr/checkbox-certification/bug1274094 into lp:checkbox-certification

Proposed by Daniel Manrique on 2014-05-28
Status: Merged
Approved by: Daniel Manrique on 2014-05-28
Approved revision: 649
Merged at revision: 649
Proposed branch: lp:~roadmr/checkbox-certification/bug1274094
Merge into: lp:checkbox-certification
Diff against target: 28 lines (+4/-2)
2 files modified
debian/changelog (+3/-1)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~roadmr/checkbox-certification/bug1274094
Reviewer Review Type Date Requested Status
Daniel Manrique Approve on 2014-05-28
Review via email: mp+221237@code.launchpad.net

Commit message

Remove dependency on checkbox from checkbox-certification-tools (because it doesn't strictly speaking require checkbox to function), but add python3-requests, because it does need that to function.

Description of the change

Remove dependency on checkbox from checkbox-certification-tools (because it doesn't strictly speaking require checkbox to function), but add python3-requests, because it does need that to function.

A resubmit/fix of https://code.launchpad.net/~brendan-donegan/checkbox-certification/bug1274094

To post a comment you must log in.
Daniel Manrique (roadmr) wrote :

This is exactly the same code as https://code.launchpad.net/~brendan-donegan/checkbox-certification/bug1274094/+merge/204360 save for the changelog fix, so I'll self-approve since that one was already approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-02-14 17:13:06 +0000
3+++ debian/changelog 2014-05-28 13:56:54 +0000
4@@ -13,8 +13,10 @@
5
6 [ Brendan Donegan ]
7
8- * Changed python3 to python3-all in Build-Depends.
9+ * Changed python3 to python3-all in Build-Depends.
10 * Removed whitelists because they're now in checkbox.
11+ * Removed dependency on checkbox from checkbox-certification-tools
12+ and added a dependency on python3-requests (LP: #1274094)
13
14 -- Zygmunt Krynicki <zygmunt.krynicki@canonical.com> Fri, 14 Feb 2014 18:04:17 +0100
15
16
17=== modified file 'debian/control'
18--- debian/control 2014-01-17 16:59:28 +0000
19+++ debian/control 2014-05-28 13:56:54 +0000
20@@ -55,7 +55,7 @@
21 Section: python
22 Architecture: all
23 Priority: standard
24-Depends: checkbox (>= 0.16~ppa), python3-pkg-resources, ${python3:Depends}
25+Depends: python3-pkg-resources, python3-requests, ${python3:Depends}
26 Description: Checkbox Certification Tools
27 This package contains additional, useful tools to aid in the certification
28 process.

Subscribers

People subscribed via source and target branches