Code review comment for ~rmescandon/snappy-hwe-snaps/+git/wifi-connect:config-ui

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Adding some notes from external conversation:

config content should be always available (not just on first use)

config content should show on first use of management portal and be available from management portal at any later time

config content should physically be part of management.html (not in a separate html page). Visibility of parts is controlled by css appropriately.

Just to be clear, pre-config.json should NEVER be written to since it represents the system-integrator's pre config via gadget, if any

The only value you need to read from pre-config.json is portal.no-reset-creds. If this is true, then the user is not required to reset the portal password and the wifi passphrase on first use.

I don't think we need to write any config.json. Any changed values should be set after form validates in wifi-ap (and the portal password if that is set)

All params on the config page except for portal.password should get their values for display from wifi-ap (no local storage of these values)

Emtpy fields (except for portal password and wifi passprhase) should cause form validation error.

After form validates, only changed params should be set. This prevents wifi-ap DOWN>UP if not needed.

review: Needs Fixing

« Back to merge proposal