Code review comment for ~rmccabe/cloud-init:bug1705804-4

Revision history for this message
Scott Moser (smoser) wrote :

Ryan,
One question inline.

Also, rebase on master and push and the bot will re-test which will hopefully be happy (trunk was busted, causing the failure that it reported).

Last, i think the "listify" that you're doing better fits in 'normalize_subnets'

  http://paste.ubuntu.com/26007995/

Try that diff on top of yours and see what you think.

take it and re-push and we should be good.

review: Needs Fixing

« Back to merge proposal