Code review comment for lp:~rlane/nova/ldap-user-modify-only

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

The attempt to merge lp:~rlane/nova/ldap-user-modify-only into lp:nova failed. Below is the output from the failed tests.

nova/auth/ldapdriver.py:141:24: W601 .has_key() is deprecated, use 'in'
                if user.has_key('secretKey'):
                       ^
    The {}.has_key() method will be removed in the future version of
    Python. Use the 'in' operation instead, like:
    d = {"a": 1, "b": 2}
    if "b" in d:
        print d["b"]
nova/auth/ldapdriver.py:147:24: W601 .has_key() is deprecated, use 'in'
                if user.has_key('accessKey'):
                       ^
    The {}.has_key() method will be removed in the future version of
    Python. Use the 'in' operation instead, like:
    d = {"a": 1, "b": 2}
    if "b" in d:
        print d["b"]
nova/auth/ldapdriver.py:153:24: W601 .has_key() is deprecated, use 'in'
                if user.has_key('isAdmin'):
                       ^
    The {}.has_key() method will be removed in the future version of
    Python. Use the 'in' operation instead, like:
    d = {"a": 1, "b": 2}
    if "b" in d:
        print d["b"]
nova/auth/ldapdriver.py:162:80: E501 line too long (83 characters)
                raise exception.NotFound("LDAP object for %s doesn't exist" % name)
                                                                               ^
    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
    lines; plus, limiting windows to 80 characters makes it possible to have
    several windows side-by-side. The default wrapping on such devices looks
    ugly. Therefore, please limit all lines to a maximum of 79 characters.
    For flowing long blocks of text (docstrings or comments), limiting the
    length to 72 characters is recommended.
nova/auth/ldapdriver.py:300:20: W601 .has_key() is deprecated, use 'in'
            if user.has_key('secretKey'):
                   ^
    The {}.has_key() method will be removed in the future version of
    Python. Use the 'in' operation instead, like:
    d = {"a": 1, "b": 2}
    if "b" in d:
        print d["b"]
nova/auth/ldapdriver.py:303:20: W601 .has_key() is deprecated, use 'in'
            if user.has_key('accessKey'):
                   ^
    The {}.has_key() method will be removed in the future version of
    Python. Use the 'in' operation instead, like:
    d = {"a": 1, "b": 2}
    if "b" in d:
        print d["b"]
nova/auth/ldapdriver.py:306:20: W601 .has_key() is deprecated, use 'in'
            if user.has_key('isAdmin'):
                   ^
    The {}.has_key() method will be removed in the future version of
    Python. Use the 'in' operation instead, like:
    d = {"a": 1, "b": 2}
    if "b" in d:
        print d["b"]
nova/auth/ldapdriver.py:515:17: W601 .has_key() is deprecated, use 'in'
        if (attr.has_key('accessKey') and attr.has_key('secretKey') \
                ^
    The {}.has_key() method will be removed in the future version of
    Python. Use the 'in' operation instead, like:
    d = {"a": 1, "b": 2}
    if "b" in d:
        print d["b"]

« Back to merge proposal