Code review comment for lp:~rlaager/ecryptfs/fix-lp-1574174

Tyler Hicks (tyhicks) wrote :

Hi Richard - Thanks for the merge proposal. I could be wrong because I didn't test this but I think adding a leading space to CRYPTDIR would break the "already mounted" check since CRYPTDIR is the device (or source) and will be listed at the beginning of a line in /proc/mounts. The check will never fail even if the CRYPTDIR is already mounted.

review: Needs Fixing

« Back to merge proposal