Merge ~rjschwei/cloud-init:systemdTmpl into cloud-init:master

Proposed by Robert Schweikert
Status: Merged
Approved by: Scott Moser
Approved revision: 15baabd39e602cf12b2030eed6b24ab22f94e49e
Merged at revision: 15baabd39e602cf12b2030eed6b24ab22f94e49e
Proposed branch: ~rjschwei/cloud-init:systemdTmpl
Merge into: cloud-init:master
Diff against target: 17 lines (+0/-6)
1 file modified
systemd/cloud-init-local.service.tmpl (+0/-6)
Reviewer Review Type Date Requested Status
Scott Moser Approve
Ryan Harper Approve
Server Team CI bot continuous-integration Approve
Review via email: mp+333940@code.launchpad.net

Description of the change

As promised a while ago, I investigated the questionable condition for SUSE based distros in cloud-init-local.service. This is the fix/result of the investigation the condition for Before=basic.target should not exist.

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:15baabd39e602cf12b2030eed6b24ab22f94e49e
https://jenkins.ubuntu.com/server/job/cloud-init-ci/514/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    SUCCESS: Ubuntu LTS: Integration
    SUCCESS: MAAS Compatability Testing
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/514/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ryan Harper (raharper) wrote :

LGTM

review: Approve
Revision history for this message
Scott Moser (smoser) wrote :

I'll rewrite the commit message to be

 Subjectm ...
 <blank linke>
 description

and then will pull this.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/systemd/cloud-init-local.service.tmpl b/systemd/cloud-init-local.service.tmpl
2index bf6b296..ff9c644 100644
3--- a/systemd/cloud-init-local.service.tmpl
4+++ b/systemd/cloud-init-local.service.tmpl
5@@ -13,12 +13,6 @@ Before=shutdown.target
6 Before=sysinit.target
7 Conflicts=shutdown.target
8 {% endif %}
9-{% if variant in ["suse"] %}
10-# Other distros use Before=sysinit.target. There is not a clearly identified
11-# reason for usage of basic.target instead.
12-Before=basic.target
13-Conflicts=shutdown.target
14-{% endif %}
15 RequiresMountsFor=/var/lib/cloud
16
17 [Service]

Subscribers

People subscribed via source and target branches