Code review comment for ~rjschwei/cloud-init:netV1ToTranslate

Revision history for this message
Chad Smith (chad.smith) wrote :

Robert, I agree on your suggestion to not be too flexible for future formats etc. So +1 on dropping my other re.match suggestion on 'default gw' handling. Yeah no need to waste resources planning for future-formats if we don't need to. Per your handling is duplicate (list type) entries in post-up, did you have specific use-cases in mind where multiple post-up commands are specified in /etc/network/interfaces in a single iface stanza?

review: Needs Information

« Back to merge proposal