Code review comment for lp:~ris/unity-2d/fix-729478

Revision history for this message
Aurélien Gâteau (agateau) wrote :

Hi Robert,

Thanks for this patch, works well! I just have a few nitpicks:

- Indentation in launcher/LauncherList.qml is wrong: it mixes tabs and spaces

- Since LauncherApplication::newInstance() just calls LauncherApplication::launch(), it is simpler to just call launch(). You only have to make it a public slot.

review: Needs Fixing

« Back to merge proposal