Code review comment for lp:~ris/unity-2d/fix-692444
Revision history for this message
| Robert Sajdok (ris) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> Code in Trash::running() and Trash::show() is mostly duplicated. Code
> duplication could be avoided by creating a utility method that returns the
> first BamfWindow corresponding to the trash if it exists:
>
> BamfWindow* firstWindow();
Yes I know, but please note that the method "show ()" does not stop after finding the first window: "Trash". This method "show ()" shows all the windows, whose name is "Trash"