Code review comment for lp:~ris/unity-2d/fix-692444

Revision history for this message
Florian Boucault (fboucault) wrote :

Duplicating LauncherApplication::showWindow with Trash::showWindow is something that should be avoided as well. Same for LauncherApplication::moveViewportToWindow. One could think of a separate utility class/namespace where these 2 would go but for now it is just simpler to call LauncherApplication::showWindow directly from Trash's code.

review: Needs Fixing (code)

« Back to merge proposal