Code review comment for lp:~riddlepl/granite/trunk

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Introducing an ABI break of this kind is not welcome. You didnt even gave an explaination for your changes.

Adding new methods is fine while preserve the old ones to give reverse-depends the time to settle. You can use the "[Deprecated ...]" vala-annoation to propagate a change is needed in the future.

« Back to merge proposal