Code review comment for lp:~ricotz/docky/desktopswitcher

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

> 1) It doesnt 'wrap' when I scroll over it. I realize for some cases this is hard to figure out, and honestly I dont know the answer (for square layouts). But for purely horizontal/vertical layouts it makes perfect sense and needs to be there.

I will implement it this way. If there is a one row/col layout it will
wrap around. On multi row and column layouts scrolling will walk through
line by line and jump from [1,1] to [n,n]

> 2) what is this 'folder' (??) icon on the active desktop?

Just the theme icon for "desktop" to mark it in a proper/colored way to
match the current icon theme.

> 3) Should the hover text update itself based on what portion is hovered? IE, hover desk 1 and the hover shows 'desk 1' etc, instead of always showing the current desk - that way, you get a hover for what you are about to click on which makes it easier.... i am not even sure our API allows this, but lets first figure out if it makes sense and go from there :)

Will need some core changes to do this, so shelve this idea for now.

« Back to merge proposal