Code review comment for lp:~ricmm/platform-api/v2-dynamic-refactor

Revision history for this message
Thomas Voß (thomas-voss) wrote :

Hey Ricardo,

thanks for the massive cleanup effort here :) Looks good so far, a minor niggle:

  * l. 1804: Commented out, please remove.

For MODULE_VERSION: I was thinking if we should resort to MODULE_VERSION_{MAJOR,MINOR,PATCH}, and make the individual modules export a function u_module_version(int major, int minor, int patch) to allow for some basic version checking at runtime. If the runtime version checking is already in place -> apologies, the MP is quite large.

review: Needs Fixing

« Back to merge proposal