Merge lp:~ricmm/mediaplayer-app/no-clip into lp:mediaplayer-app

[Ricardo Mendoza]

Bug #1417006
Performance/Rendering fixes:
 * Remove clipping on video loader
 * Remove unused rectangles (overdraw)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:349
http://jenkins.qa.ubuntu.com/job/mediaplayer-app-ci/263/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2505
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/829/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-vivid-amd64-ci/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-vivid-armhf-ci/21
        deb: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-vivid-armhf-ci/21/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-vivid-i386-ci/21
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2170
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2503
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2503/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19994
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/662/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/991
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/991/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mediaplayer-app-ci/263/rebuild

review: Needs Fixing (continuous-integration)

[Ricardo Salveti (rsalveti)]

Looks good and works as expected.

review: Approve

=== modified file 'src/qml/player.qml'
--- src/qml/player.qml	2014-10-15 21:26:33 +0000
+++ src/qml/player.qml	2015-04-28 18:57:02 +0000
@@ -26,8 +26,7 @@
 import Ubuntu.Components 1.1
 import Ubuntu.Components.Popups 1.0 as Popups
 
-
-Rectangle {
+Item {
     id: mediaPlayer
     width: screenWidth
     height: screenHeight
@@ -81,7 +80,6 @@
         source: "player/VideoPlayer.qml"
         focus: true
         anchors.fill: parent
-        clip: true
         onLoaded: {
             item.focus = true
             item.rotating = Qt.binding(function () { return rotatingTransition.running } )
 
=== modified file 'src/qml/player/AbstractPlayer.qml'
--- src/qml/player/AbstractPlayer.qml	2015-03-20 17:34:56 +0000
+++ src/qml/player/AbstractPlayer.qml	2015-04-28 18:57:02 +0000
@@ -23,7 +23,7 @@
 import "../common"
 import "../common/utils.js" as Utils
 
-Rectangle {
+Item {
     id: player
 
     property bool playing: state == "playing"
@@ -44,7 +44,6 @@
 
     objectName: "videoPlayer"
     state: "stopped"
-    color: "black"
 
     function stop() {
         state = "stopped"