Code review comment for lp:~rick-rickspencer3/quidgets/gio_prompts

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

From the tests:
if I answer "Cancel" on the first "Open" dialog, I get a traceback:
python prompts/__init__.py
response was not OK
Traceback (most recent call last):
  File "prompts/__init__.py", line 977, in <module>
    print "selected directory was " + val
TypeError: cannot concatenate 'str' and 'NoneType' objects

All the rest of the tests are passing fine with both "ok" and "cancel".

Some remarks:

- gtk.Dialog.__init__(self, title, None, gtk.DIALOG_MODAL,(gtk.STOCK_CANCEL, gtk.RESPONSE_CANCEL, gtk.STOCK_OK, gtk.RESPONSE_OK))
69 - self.set_has_separator(False)
70 + Gtk.Dialog.__init__(self, title, None, Gtk.DialogFlags.MODAL,(Gtk.STOCK_CANCEL, Gtk.ResponseType.CANCEL, Gtk.STOCK_OK, Gtk.ResponseType.OK))
71 + #self.set_has_separator(False)
-> is this wanted that it's commented right now? (it was used before) Same with a lot of other set_has_separator. It seems to be in pygi and is even ued in the Gtk override file: /usr/share/pyshared/gi/overrides/Gtk.py

242 + self._spinner.set_adjustment(adj)
243 + #adj,1,0
-> same comment (you added adj, 1, 0 before)

314 - self._spinner = gtk.SpinButton(self._adjustment,1,digits)
315 + self._spinner = Gtk.SpinButton()
316 + self._spinner.set_adjustment(self._adjustment)
317 + self._spinner.set_digits(digits)#,1,digits)
-> same :)

451 - yes_button.set_flags(gtk.CAN_DEFAULT)
452 -
453 -
454 - self.set_has_separator(False)
455 + yes_button.set_can_default(True)
456 +
457 +
458 + #self.set_has_separator(False)
-> same :)

559 - gtk.Dialog.__init__(self, title,None,gtk.DIALOG_MODAL,(gtk.STOCK_OK, gtk.RESPONSE_OK))
560 - self.set_has_separator(False)
561 + Gtk.Dialog.__init__(self, title,None,Gtk.DialogFlags.MODAL,(Gtk.STOCK_OK, Gtk.ResponseType.OK))
562 + #self.set_has_separator(False)
-> same same same ;)

review: Needs Fixing

« Back to merge proposal