Code review comment for lp:~richard-wilbur/bzr/1537319-reproducible-builds

Revision history for this message
Vincent Ladeuil (vila) wrote :

Hmm.

This looks like a rabbit hole :-/

Overall, this is going in the right direction but I think this will end up in several MPs.

There is duplicated code you're modifying which is worth refactoring as are the duplicate doc Makefiles.

Not to mention the comments (I feel your pain :-/) you had to modify to maintain consistency.

And we need more tests :) At least a setup where we can build all docs and see the results to start with.

« Back to merge proposal