Merge lp:~ricgard/maas/device-button-positioning into lp:~maas-committers/maas/trunk

Proposed by Richard McCartney
Status: Merged
Approved by: Andres Rodriguez
Approved revision: no longer in the source branch.
Merged at revision: 4374
Proposed branch: lp:~ricgard/maas/device-button-positioning
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 39 lines (+13/-13)
1 file modified
src/maasserver/static/partials/nodes-list.html (+13/-13)
To merge this branch: bzr merge lp:~ricgard/maas/device-button-positioning
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Review via email: mp+274229@code.launchpad.net

Commit message

REsolving device listing layout issue in the page header

Description of the change

Amending the markup on device listing to fix the page header button layout issue.

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/maasserver/static/partials/nodes-list.html'
--- src/maasserver/static/partials/nodes-list.html 2015-09-30 18:42:27 +0000
+++ src/maasserver/static/partials/nodes-list.html 2015-10-13 10:12:39 +0000
@@ -239,22 +239,22 @@
239 <div data-ng-show="currentpage === 'devices'">239 <div data-ng-show="currentpage === 'devices'">
240 <div class="page-header__actions">240 <div class="page-header__actions">
241 <div class="page-header__cta" data-ng-hide="tabs.devices.selectedItems.length">241 <div class="page-header__cta" data-ng-hide="tabs.devices.selectedItems.length">
242 <button class="cta-ubuntu"242 <div class="right">
243 data-ng-click="addDevice()"243 <button class="cta-ubuntu"
244 data-ng-hide="addDeviceScope.viewable">Add Device</button>244 data-ng-click="addDevice()"
245 <button class="cta-ubuntu secondary ng-hide"245 data-ng-hide="addDeviceScope.viewable">Add Device</button>
246 data-ng-click="cancelAddDevice()"246 <button class="cta-ubuntu secondary ng-hide"
247 data-ng-show="addDeviceScope.viewable">Cancel add device</button>247 data-ng-click="cancelAddDevice()"
248 data-ng-show="addDeviceScope.viewable">Cancel add device</button>
249 </div>
248 </div>250 </div>
249 <div class="page-header__cta ng-hide four-col no-margin-bottom" data-ng-show="tabs.devices.selectedItems.length">251 <div class="page-header__cta ng-hide" data-ng-show="tabs.devices.selectedItems.length">
250 <span class="page-header__cta-feedback two-col no-margin-bottom" data-ng-click="showSelected('devices')">252 <span class="page-header__cta-feedback" data-ng-click="showSelected('devices')">
251 {$ tabs.devices.selectedItems.length $} Selected253 {$ tabs.devices.selectedItems.length $} Selected
252 </span>254 </span>
253 <div class="two-col no-margin-bottom last-col">255 <div data-maas-cta="tabs.devices.takeActionOptions"
254 <div data-maas-cta="tabs.devices.takeActionOptions"256 data-ng-model="tabs.devices.actionOption"
255 data-ng-model="tabs.devices.actionOption"257 data-ng-change="actionOptionSelected('devices')">
256 data-ng-change="actionOptionSelected('devices')">
257 </div>
258 </div>258 </div>
259 </div>259 </div>
260 </div>260 </div>