Merge lp:~ricgard/maas/device-button-positioning into lp:~maas-committers/maas/trunk

Proposed by Richard McCartney
Status: Merged
Approved by: Andres Rodriguez
Approved revision: no longer in the source branch.
Merged at revision: 4374
Proposed branch: lp:~ricgard/maas/device-button-positioning
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 39 lines (+13/-13)
1 file modified
src/maasserver/static/partials/nodes-list.html (+13/-13)
To merge this branch: bzr merge lp:~ricgard/maas/device-button-positioning
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Review via email: mp+274229@code.launchpad.net

Commit message

REsolving device listing layout issue in the page header

Description of the change

Amending the markup on device listing to fix the page header button layout issue.

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/maasserver/static/partials/nodes-list.html'
2--- src/maasserver/static/partials/nodes-list.html 2015-09-30 18:42:27 +0000
3+++ src/maasserver/static/partials/nodes-list.html 2015-10-13 10:12:39 +0000
4@@ -239,22 +239,22 @@
5 <div data-ng-show="currentpage === 'devices'">
6 <div class="page-header__actions">
7 <div class="page-header__cta" data-ng-hide="tabs.devices.selectedItems.length">
8- <button class="cta-ubuntu"
9- data-ng-click="addDevice()"
10- data-ng-hide="addDeviceScope.viewable">Add Device</button>
11- <button class="cta-ubuntu secondary ng-hide"
12- data-ng-click="cancelAddDevice()"
13- data-ng-show="addDeviceScope.viewable">Cancel add device</button>
14+ <div class="right">
15+ <button class="cta-ubuntu"
16+ data-ng-click="addDevice()"
17+ data-ng-hide="addDeviceScope.viewable">Add Device</button>
18+ <button class="cta-ubuntu secondary ng-hide"
19+ data-ng-click="cancelAddDevice()"
20+ data-ng-show="addDeviceScope.viewable">Cancel add device</button>
21+ </div>
22 </div>
23- <div class="page-header__cta ng-hide four-col no-margin-bottom" data-ng-show="tabs.devices.selectedItems.length">
24- <span class="page-header__cta-feedback two-col no-margin-bottom" data-ng-click="showSelected('devices')">
25+ <div class="page-header__cta ng-hide" data-ng-show="tabs.devices.selectedItems.length">
26+ <span class="page-header__cta-feedback" data-ng-click="showSelected('devices')">
27 {$ tabs.devices.selectedItems.length $} Selected
28 </span>
29- <div class="two-col no-margin-bottom last-col">
30- <div data-maas-cta="tabs.devices.takeActionOptions"
31- data-ng-model="tabs.devices.actionOption"
32- data-ng-change="actionOptionSelected('devices')">
33- </div>
34+ <div data-maas-cta="tabs.devices.takeActionOptions"
35+ data-ng-model="tabs.devices.actionOption"
36+ data-ng-change="actionOptionSelected('devices')">
37 </div>
38 </div>
39 </div>