Code review comment for lp:~ricardokirkner/ols-store-tests/more-acceptance-tests

Revision history for this message
James Tait (jamestait) wrote :

Yep, looks good to me. I've made a couple of suggestions, but they are just that - this is good to land as-is, IMO.

As an aside, we're hard-coding some assumptions about URL structure (e.g. appending click-package-name or snap-package-id to /api/v1/package), which may not hold true longer-term. I think that's probably OK for these tests, since we *want* to know if URLs change, and I don't think *any* of the clients are actually parsing the links from the root resource anyway.

review: Approve

« Back to merge proposal