Merge lp:~ricardokirkner/django-preflight/865623-overview-with-requestcontext into lp:django-preflight

[Ricardo Kirkner]

use a RequestContext instance when rendering the overview page

Makes preflight work with templates depending on the STATIC_URL var provided by django's 1.3 static template context processor by using a RequestContext when rendering the response.

[David Owen (dsowen)]

review: Approve

=== modified file 'preflight/tests.py'
--- preflight/tests.py	2011-03-18 22:24:43 +0000
+++ preflight/tests.py	2011-10-03 19:19:23 +0000
@@ -3,7 +3,10 @@
 import sys
 
 from django.core.management import call_command
+from django.core.urlresolvers import reverse
+from django.http import HttpResponse
 from django.test import TestCase
+from django.template import RequestContext, TemplateDoesNotExist
 from mock import patch
 
 from cStringIO import StringIO
@@ -219,3 +222,25 @@
             self.assertTrue('checks for applications' in sys.stdout.getvalue())
         finally:
             sys.stdout = sys.__stdout__
+
+
+class OverviewView(TestCase):
+    @patch('preflight.views.authenticate')
+    def test_overview_when_not_authenticated(self, mock_authenticate):
+        mock_authenticate.return_value = False
+
+        self.assertRaises(TemplateDoesNotExist, self.client.get,
+            reverse('preflight-overview'))
+
+    @patch('preflight.views.render_to_response')
+    @patch('preflight.views.authenticate')
+    def test_overview(self, mock_authenticate, mock_render_to_response):
+        mock_authenticate.return_value = True
+        mock_render_to_response.return_value = HttpResponse()
+
+        self.client.get(reverse('preflight-overview'))
+
+        mock_render_to_response.assert_called_once()
+        context = mock_render_to_response.call_args[0][1]
+        self.assertTrue(isinstance(context, RequestContext))
+
 
=== modified file 'preflight/views.py'
--- preflight/views.py	2011-02-07 16:06:51 +0000
+++ preflight/views.py	2011-10-03 19:19:23 +0000
@@ -7,6 +7,7 @@
 from django.http import Http404
 from django.conf import settings
 from django.shortcuts import render_to_response
+from django.template import RequestContext
 
 from .models import authenticate, gather_checks, gather_versions
 
@@ -20,10 +21,11 @@
                             "index.1col.html")
     table_class = getattr(settings, 'PREFLIGHT_TABLE_CLASS', "listing")
 
-    return render_to_response("preflight/overview.html", {
+    context = RequestContext(request, {
         "applications": gather_checks(),
         "versions": gather_versions(),
         "now": datetime.now(),
         "preflight_base_template": base_template,
         'preflight_table_class': table_class,
     })
+    return render_to_response("preflight/overview.html", context)