Merge lp:~ricardokirkner/django-adminaudit/1188250-getting-bigger into lp:django-adminaudit

[Ricardo Kirkner]

removed size constraints from username, model and representation fields

This branch removes size constraints on certain AuditLog columns. This should fix bug # when deployed.

As sqlite will happily ignore constraints, tests needed to be smarted about it. They are inspired by this post: http://stackoverflow.com/questions/8478054/django-model-charfield-max-length-does-not-work

[Matias Bordese (matiasb)]

Looks good.

review: Approve

=== added file 'adminaudit/migrations/0002_auto__chg_field_auditlog_username__chg_field_auditlog_representation__.py'
--- adminaudit/migrations/0002_auto__chg_field_auditlog_username__chg_field_auditlog_representation__.py	1970-01-01 00:00:00 +0000
+++ adminaudit/migrations/0002_auto__chg_field_auditlog_username__chg_field_auditlog_representation__.py	2013-06-07 19:09:29 +0000
@@ -0,0 +1,46 @@
+# -*- coding: utf-8 -*-
+import datetime
+from south.db import db
+from south.v2 import SchemaMigration
+from django.db import models
+
+
+class Migration(SchemaMigration):
+
+    def forwards(self, orm):
+
+        # Changing field 'AuditLog.username'
+        db.alter_column(u'adminaudit_auditlog', 'username', self.gf('django.db.models.fields.TextField')())
+
+        # Changing field 'AuditLog.representation'
+        db.alter_column(u'adminaudit_auditlog', 'representation', self.gf('django.db.models.fields.TextField')())
+
+        # Changing field 'AuditLog.model'
+        db.alter_column(u'adminaudit_auditlog', 'model', self.gf('django.db.models.fields.TextField')())
+
+    def backwards(self, orm):
+
+        # Changing field 'AuditLog.username'
+        db.alter_column(u'adminaudit_auditlog', 'username', self.gf('django.db.models.fields.CharField')(max_length=255))
+
+        # Changing field 'AuditLog.representation'
+        db.alter_column(u'adminaudit_auditlog', 'representation', self.gf('django.db.models.fields.CharField')(max_length=255))
+
+        # Changing field 'AuditLog.model'
+        db.alter_column(u'adminaudit_auditlog', 'model', self.gf('django.db.models.fields.CharField')(max_length=255))
+
+    models = {
+        u'adminaudit.auditlog': {
+            'Meta': {'object_name': 'AuditLog'},
+            'change': ('django.db.models.fields.CharField', [], {'max_length': '100'}),
+            'created_at': ('django.db.models.fields.DateTimeField', [], {'auto_now_add': 'True', 'blank': 'True'}),
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'model': ('django.db.models.fields.TextField', [], {}),
+            'representation': ('django.db.models.fields.TextField', [], {}),
+            'user_id': ('django.db.models.fields.IntegerField', [], {}),
+            'username': ('django.db.models.fields.TextField', [], {}),
+            'values': ('django.db.models.fields.TextField', [], {})
+        }
+    }
+
+    complete_apps = ['adminaudit']
 \ No newline at end of file
 
=== modified file 'adminaudit/models.py'
--- adminaudit/models.py	2012-08-21 17:39:18 +0000
+++ adminaudit/models.py	2013-06-07 19:09:29 +0000
@@ -12,11 +12,11 @@
     Records of all changes made via Django admin interface.
 
     """
-    username = models.CharField(max_length=255)
+    username = models.TextField()
     user_id = models.IntegerField()
-    model = models.CharField(max_length=255)
+    model = models.TextField()
     change = models.CharField(max_length=100)
-    representation = models.CharField(max_length=255)
+    representation = models.TextField()
     values = models.TextField()
     created_at = models.DateTimeField(auto_now_add=True)
 
 
=== modified file 'adminaudit/tests.py'
--- adminaudit/tests.py	2012-04-26 16:39:32 +0000
+++ adminaudit/tests.py	2013-06-07 19:09:29 +0000
@@ -44,6 +44,39 @@
         self.client.login(username='test', password='test')
 
 
+class AuditLogTestCase(TestCase):
+    def make_log_data(self, **overrides):
+        data = {
+            'username': 'test',
+            'user_id': 1,
+            'model': 'model',
+            'change': 'change',
+            'representation': 'representation',
+            'values': 'values',
+        }
+        data.update(overrides)
+        return data
+
+    def assert_log_valid(self, data):
+        log = AuditLog(**data)
+        # force model validation
+        # full_clean raises a ValidationError if object doesn't validate with
+        # model.
+        log.full_clean()
+
+    def test_long_username(self):
+        data = self.make_log_data(username='a'*500)
+        self.assert_log_valid(data)
+
+    def test_long_model(self):
+        data = self.make_log_data(model='a'*500)
+        self.assert_log_valid(data)
+
+    def test_long_representation(self):
+        data = self.make_log_data(representation='a'*500)
+        self.assert_log_valid(data)
+
+
 class AuditAdminEmailReportTestCase(TestCase):
 
     def create_and_log_in_user(self, **kwargs):
 
=== modified file 'setup.py'
--- setup.py	2013-06-07 19:09:29 +0000
+++ setup.py	2013-06-07 19:09:29 +0000
@@ -27,7 +27,7 @@
 setup(
     # metadata
     name='django-adminaudit',
-    version='0.3.4',
+    version='0.4.0',
     description="Extends Django's admin logging capabilities",
     url='https://launchpad.net/django-adminaudit',
     author='Łukasz Czyżykowski',