Launchpad itself

Code review comment for lp:~rharding/launchpad/related_projects_1063272

  1. related_projects_1063272
  2. Merge into devel
Revision history for this message
Brad Crittenden (bac) wrote :

Hi Rick,

Some comments on your branch:

* In genAffiliatedProductSql there is a lot of repetition in the queries that could be factored out so you DRY as the first query you return is a the same as the final one minus one clause. Give a shot at refactoring if you don't mind.

* Thanks for the nice error messages when the account cannot be deactivated.

* The tests are clear and easy to follow. Thanks.

review: Approve (code)

« Back to merge proposal