Code review comment for lp:~rharding/juju-gui/qa-ant-onboarding

https://codereview.appspot.com/14700043/diff/15001/app/views/onboarding.js
File app/views/onboarding.js (right):

https://codereview.appspot.com/14700043/diff/15001/app/views/onboarding.js#newcode136
app/views/onboarding.js:136: crossHandler: function(ev) {
On 2013/10/16 17:52:32, gary.poster wrote:
> (1) this is also registered for mouseup. Why?
> (2) Other than the blasted documentation blather :-D, this feels like
it would
> be cleaner as separate methods, one for each event. That's a
suggestion: take
> it or leave it.
> (3) .replaceClass(..., ...) could make each type into single calls.
> (4) I hope the close-inspector-click style wins over the -hover or
-normal
> styles, or that they get along somehow. I'll assume they do.

1. The mouse up event calls closeHandler
2. I'll leave this for now but happy to update if required
3. Brilliant, done.
4. The close-inspector-click displays a brighter cross.

https://codereview.appspot.com/14700043/