https://codereview.appspot.com/14700043/diff/1/app/app.js#newcode1140
app/app.js:1140: this._onboarding.close();
On 2013/10/15 16:27:00, rharding wrote:
> On 2013/10/15 16:13:05, Ant wrote:
> > On 2013/10/15 14:55:34, rharding wrote:
> > > why do we need to close here? If you hit the root url, and we
render. You
> > close
> > > it with the button/control in the UI. If you're not at the / url
then we
> never
> > > show this and there's nothing to close?
> >
> > This is used when the user use's the browsers navigation buttons to
jump form
> > build and browse.
> When they go from browse to build though the url changes and will no
longer be
> /. So I think it's safe to leave this out.
https:/ /codereview. appspot. com/14700043/ diff/1/ app/app. js
File app/app.js (right):
https:/ /codereview. appspot. com/14700043/ diff/1/ app/app. js#newcode1140 g.close( );
app/app.js:1140: this._onboardin
On 2013/10/15 16:27:00, rharding wrote:
> On 2013/10/15 16:13:05, Ant wrote:
> > On 2013/10/15 14:55:34, rharding wrote:
> > > why do we need to close here? If you hit the root url, and we
render. You
> > close
> > > it with the button/control in the UI. If you're not at the / url
then we
> never
> > > show this and there's nothing to close?
> >
> > This is used when the user use's the browsers navigation buttons to
jump form
> > build and browse.
> When they go from browse to build though the url changes and will no
longer be
> /. So I think it's safe to leave this out.
Ok, taking it out.
https:/ /codereview. appspot. com/14700043/