Code review comment for lp:~rharding/juju-gui/help-dropdown

Revision history for this message
Richard Harding (rharding) wrote :

Reviewers: mp+195116_code.launchpad.net,

Message:
Please take a look.

Description:
A dropdown view extension.

This is a refactoring of Huw's branch which created a dropdown widget
  and a "Help & Feedback" dropdown on the header bar.

  original: https://codereview.appspot.com/23410043/

  original original: https://codereview.appspot.com/25390043/

https://code.launchpad.net/~rharding/juju-gui/help-dropdown/+merge/195116

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/26200043/

Affected files (+675, -259 lines):
   A [revision details]
   M app/app.js
   A app/assets/javascripts/view-dropdown-extension.js
   M app/index.html
   M app/modules-debug.js
   M app/subapps/browser/browser.js
   A app/templates/help-dropdown.handlebars
   M app/templates/notifications.handlebars
   M app/templates/onboarding.handlebars
   M app/templates/overview.handlebars
   A app/views/help-dropdown.js
   M app/views/notifications.js
   M app/views/onboarding.js
   M bin/merge-files
   M lib/views/browser/onboarding.less
   M lib/views/dropdown.less
   M lib/views/stylesheet.less
   M test/index.html
   M test/test_browser_app.js
   A test/test_dropdown_extension.js
   A test/test_help_dropdown.js
   M test/test_notifications.js
   M test/test_onboarding.js
   M undocumented

« Back to merge proposal