Code review comment for lp:~rharding/juju-gui/fix-file-dnd

Revision history for this message
Jeff Pihach (hatch) wrote :

Code LGTM

QA NOT OK

When dragging and dropping a bundle yaml file I get the following error:

Uncaught TypeError: Property 'handleDeployerWatch' of object
#<GoJujuAPI> is not a function sandbox.js:800
Y.extend.receive sandbox.js:800
Y.extend.send sandbox.js:114
Y.extend._send_rpc go.js:195
Y.extend.deployerWatch go.js:521
ns.BundleHelpers._watchDeployment bundle-import-helpers.js:161
(anonymous function) bundle-import-helpers.js:126
Y.extend.handleDeployerImport go.js:460
(anonymous function) oop-debug.js:378
Y.extend.dispatch_result go.js:167
CEProto.fireComplex event-custom-complex-debug.js:340
Y.CustomEvent._fire event-custom-base-debug.js:1068
ET.fire event-custom-base-debug.js:2230
Y.extend.on_message base.js:251
(anonymous function) oop-debug.js:378
Y.extend.receiveNow sandbox.js:83
(anonymous function)

https://codereview.appspot.com/29120043/

« Back to merge proposal