Code review comment for lp:~rharding/charmworld/handle-0-rev

Revision history for this message
Richard Harding (rharding) wrote :

Reviewer comments below.

https://codereview.appspot.com/23600043/diff/1/charmworld/models.py
File charmworld/models.py (right):

https://codereview.appspot.com/23600043/diff/1/charmworld/models.py#newcode1607
charmworld/models.py:1607: if self.revision is not None:
if 0 would fail, so have to check for None directly.

https://codereview.appspot.com/23600043/diff/1/charmworld/views/tests/test_proof.py
File charmworld/views/tests/test_proof.py (right):

https://codereview.appspot.com/23600043/diff/1/charmworld/views/tests/test_proof.py#newcode19
charmworld/views/tests/test_proof.py:19: store_revision=0,
to test, just make sure all tests pass with one of the default charms
being at rev 0.

https://codereview.appspot.com/23600043/

« Back to merge proposal