Code review comment for lp:~rharding/charmworld/allow-more-config-types

Revision history for this message
Richard Harding (rharding) wrote :

Reviewers: mp+194209_code.launchpad.net,

Message:
Please take a look.

Description:
Support float config type in proof.

- if we don't support validating it then ignore it for now
- add tests to each type we validate.

https://code.launchpad.net/~rharding/charmworld/allow-more-config-types/+merge/194209

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/22370044/

Affected files (+85, -20 lines):
   A [revision details]
   M charmworld/lib/proof.py
   M charmworld/lib/tests/test_proof.py

« Back to merge proposal