Code review comment for lp:~rharding/charms/precise/mongodb/persistent_storage

Although the idea is a really good one, I don't approve. I explain:

The persistent flag works, the logic where MongoDB tries to figure out where the newly created mount point is located, is subject to errors. In my opinion, it would be best to pass the device ( /dev/vdxx ) as a config option. That would alleviate some of the existing logic as it would not have to figure out where the device is. The rationale of my objection is that by passing the device explicitly, there is a chance of passing multiple devices and the charm would still work.

In my opinion, there should be a config options where the user could pass the device explicitly. Of course, this option would only be evaluated if the persistent config option is set to True.

Thanks,

Juan