Merge lp:~rharding/charms/precise/juju-gui/update-nagios into lp:~juju-gui/charms/precise/juju-gui/trunk

Proposed by Richard Harding
Status: Merged
Merged at revision: 165
Proposed branch: lp:~rharding/charms/precise/juju-gui/update-nagios
Merge into: lp:~juju-gui/charms/precise/juju-gui/trunk
Diff against target: 35 lines (+5/-3)
3 files modified
files/nrpe-external-master/check-app-access.sh (+3/-1)
revision (+1/-1)
scripts/update-nrpe.py (+1/-1)
To merge this branch: bzr merge lp:~rharding/charms/precise/juju-gui/update-nagios
Reviewer Review Type Date Requested Status
Richard Harding Approve
Review via email: mp+206964@code.launchpad.net

Commit message

Update nagios check per IS. Remove spaces.

Description of the change

Update nagios per IS request

- add all good to the check
- remove spaces from nagios names
- add curl -s to quiet output

To post a comment you must log in.
Revision history for this message
Richard Harding (rharding) wrote :

Self reviewing trivial. Tests pass.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'files/nrpe-external-master/check-app-access.sh'
2--- files/nrpe-external-master/check-app-access.sh 2013-08-14 21:11:26 +0000
3+++ files/nrpe-external-master/check-app-access.sh 2014-02-18 15:24:34 +0000
4@@ -8,9 +8,11 @@
5 exit 2
6 fi
7
8-match=$(curl -k $ADDRESS | grep "$LIFE_SIGN")
9+match=$(curl -s -k $ADDRESS | grep "$LIFE_SIGN")
10
11 if [[ -z $match ]]; then
12 echo juju-gui did not return content indicating it was loading.
13 exit 2
14 fi
15+
16+echo "All Good"
17
18=== modified file 'revision'
19--- revision 2014-02-05 09:21:05 +0000
20+++ revision 2014-02-18 15:24:34 +0000
21@@ -1,1 +1,1 @@
22-105
23+106
24
25=== modified file 'scripts/update-nrpe.py'
26--- scripts/update-nrpe.py 2013-08-06 13:49:06 +0000
27+++ scripts/update-nrpe.py 2014-02-18 15:24:34 +0000
28@@ -5,7 +5,7 @@
29 def update_nrpe_config():
30 nrpe_compat = nrpe.NRPE()
31 nrpe_compat.add_check(
32- 'App is accessible', 'Check the app can be downloaded',
33+ 'app-is-accessible', 'Check_the_app_can_be_downloaded',
34 'check-app-access.sh')
35 nrpe_compat.write()
36

Subscribers

People subscribed via source and target branches