Code review comment for ~rharding/charm-grafana:add-mysql-datasource

Revision history for this message
Richard Harding (rharding) wrote :

Updated the testing bundle to:

 juju deploy cs:~rharding/gypsy-danger-testing-2

This includes the changes that add the hook to properly remove the datasource when the relation is broken so that it can be readded a second time.

Tested with mysql and prometheus and verified the datasources are removed and re-add successfully.

This goes with the interfaces changes in:

https://code.launchpad.net/~rharding/interface-grafana-source/+git/interface-grafana-source/+merge/330041

« Back to merge proposal