Code review comment for ~rharding/charm-grafana:add-mysql-datasource

Revision history for this message
Paul Collins (pjdc) wrote :

A couple remarks inline. As well as this, I think it'd be valuable to have a Mojo spec to deploy grafana, etc., along with gypsy-danger and mysql and exercise the new grafana functionality so that we can CI it, although I don't know if that should be a blocker. There are a couple of likely-looking jobs on Mojo CI Jenkins, although neither passes currently:

review: Needs Fixing

« Back to merge proposal