Code review comment for ~rharding/charm-grafana:add-mysql-datasource

Revision history for this message
Jacek Nykis (jacekn) wrote :

Thanks! It's a nice addition and I only had quick look but some early feedback and questions inline. We filed RT#105512 to review and test properly.

Could you clarify what the gypsy-danger charm is? Is it mysql charm fork? Or will it proxy to the DB?

My first instinct, without knowing what the gypsy-danger is, is that if you want to talk to the DB you should relate grafana to mysql.

« Back to merge proposal