Code review comment for ~rgildein/charm-telegraf:bug1988312

Revision history for this message
Eric Chen (eric-chen) wrote :

I hope we were talking about the same thing.
I would like to know can we dectect the error caused by [1] in unit or func test?

The simplist way to approve it: apply the patch in [1] and run unit/func again. It should failed

If not, it seems we need to add this basic environment used in [2].

series: jammy
applications:
  ubuntu:
    scale: 1
    charm: ch:ubuntu
  telegraf:
    charm: ch:telegraf
    channel: candidate
relations:
  - ["ubuntu", "telegraf"]

--
[1]: https://code.launchpad.net/~hloeung/charm-telegraf/+git/charm-telegraf/+merge/428004
[2]: https://bugs.launchpad.net/charm-telegraf/+bug/1988312

« Back to merge proposal