Code review comment for lp:~rexbron/astrid/num_keyboard_fix

Revision history for this message
Andrew Hunter (rexbron) wrote :

> > Also suggesting to merge this into the 2.8.7 bugfix release.
> >
> > This is the first piece of Android software I've hacked on. I was able to
> test
> > it in an emulator but don't have spare hardware to do an on device test.
> > Hopefully I haven't made any mistakes.
>
> Looks good. I'm not going to incorporate the manifest and default.properties
> file, but otherwise, I'm going to go ahead with the merge. Thanks so much!

Cool, I updated the project to get the build.xml file to try and build astrid from the command line but ended up using eclipse instead.

« Back to merge proposal