Code review comment for lp:~renatonlima/openerp-fiscal-rules/fiscal-classification

Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

@Joël,

all right, let's say we will try it this way in the future and if it proves to be too bureaucratic, move to another group.

By the way, even if we didn't pass through the official merge proposal ceremony, Renato and me peered on that (yes at 4 AM during a go live last month on the v6.1 branch; that's the reason we cannot afford more bureaucracy) so it's not like uncertain commits in the wild. That's isn't fundamentally different than 2 C2C developers approving each others...

As for the reasons I didn't play the review game yet, it's certainly boils down to the fact that already investing on the branch extraction scripts was a huge investment for a light structure like us and as I said, migrating 15 000 lines of maturing locatization code to version 7.0 with only two people made us busy enough for not having the luxury to touch too much non localization related code these last months. I would happily peer with others for our localization. The issue is almost nobody here is making such serious investment on the localization, so we end up peering with ourselves so far. This situation is certainly related to the way OpenERP SA addresses this market that's why no matter how important the code is I never miss an occasion to give my opinion about the business model part of the project. At least we manage to peer for a few lower level modules we share with other localizations such as the Spanish one.

Also as we respect the modules used in productions by others, you'll notice that we didn't make the offence of committing these things wildly into the 6.1 "stable" branch but rather maintained our own branch here instead https://code.launchpad.net/~akretion-team/openerp-fiscal-rules/6.1-legacy for our customer pool we maintain under that 6.1 transitional branch.

Have a nice week end too and thanks again for the community work.

« Back to merge proposal