Code review comment for lp:~renatonlima/openerp-fiscal-rules/fiscal-classification

Dear Guewen and Stefan,

really I like the community review system and I promise we will submit ourselves to it the more possible. And as you can remember we are the one who spent an absurd amount of time to build the branch extraction scripts that just made the modularization possible...
Now really I think that there should have some exceptions and if you think about it, you'll see even you aren't doing any different.

So first of all Guewen, I don't want to sound harsh, but are you doing any different when you claim to rewrite the Magentoerpconnect project in v7? I'm already working on refactoring the lower level dependencies of it too... Where are these nice code review on your early prototypes? How is that different from the refactor we do in our localization?

Now about the fiscal_classification module: it happens it's a module we built for the Brazilian localization but with the hope it could be useful to other countries and this is the reason it's not built in our localization branch. But to day we are unaware of any thord party using it unfortunately... Still we promise we will do demo videos to explain the module better to get more chances to increase its adoption.

Now our business reality is that while OpenERP SA is selling partnerships to competitors leeching at our code and project image without never contributing a single line of code, just Renato Lima and me are carrying around over 15 000 lines/ 21 modules of localization alone. As you can see: it's a very tough reality that you at CampToCamp would be far from assuming when you want to raise 150k euros just to refactor the Magento connector for v7... So I mean, almost nobody is doing what we do in the conditions we do it and unfortunately it means we have to do it the way it can work for us. And the way it can work for us isn't having to wait for people who never used that code to review every little commit we do in the version; unfortunately.

So depending on your company size, location, market, maturity, realities are VERY different. You could think that only CampToCamp reality is valid. Well I would say that NONE of the larger/more comfortable companies did a tenth of what we did for our localization (or even for the Magento connector until quite recently BTW), so I think this is a clear sign that every business reality is valid and not adapting to these micro scales realities would be a terrible loss for the OpenERP eco-system.

By the way, that code as already been deployed in production in a 400 employees companies last month, so it isn't too experimental either (now the former version was utterly borken for such usage).

So again, I think module authors should be allow to opt'in for review or not if they are refactoring for new OpenERP versions. If that is not possible, well, what would happen is that we would simply move out our module from that reviewed branch (that we had started BTW) and used an unreviewed branch as the main branch. I don't think such an extremity is a good idea at all.

Instead what I think is that it's better to maximize code review but without being fanatic about it. That is: everytime you touch a third party module, you submit yourself to the review unless the change is trivial, evertime you touch a production ready module, you submit yourself to the review and the rest of the time, you try to do it when it's possible, that is not always unfortunately.

In a word, we are coming from a terrible chaos. We target a better world. That transition isn't going to happen from one day to another, we have to be flexible to allow a possible transition to better ways of working.

I hope you understand.