Merge lp:~renatofilho/webbrowser-app/fix-1359353 into lp:webbrowser-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 710
Merged at revision: 711
Proposed branch: lp:~renatofilho/webbrowser-app/fix-1359353
Merge into: lp:webbrowser-app
Diff against target: 92 lines (+59/-12)
1 file modified
src/app/webbrowser/NewTabView.qml (+59/-12)
To merge this branch: bzr merge lp:~renatofilho/webbrowser-app/fix-1359353
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+234115@code.launchpad.net

Commit message

Update the top sites visual.

To post a comment you must log in.
710. By Renato Araujo Oliveira Filho

Make backgroud image async.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:710
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1082/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4692/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3461
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-amd64-ci/281
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/281
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/281/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-i386-ci/281
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4466/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5944
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5944/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13023
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2863
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3766
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3766/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1082/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

tested, works
Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
yes

Did CI run pass? If not, please explain why.
yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/app/webbrowser/NewTabView.qml'
--- src/app/webbrowser/NewTabView.qml 2014-07-29 22:31:49 +0000
+++ src/app/webbrowser/NewTabView.qml 2014-09-10 13:53:17 +0000
@@ -163,22 +163,17 @@
163163
164 delegate: MouseArea {164 delegate: MouseArea {
165 width: units.gu(18)165 width: units.gu(18)
166 height: units.gu(22)166 height: childrenRect.height
167167
168 Column {168 Column {
169 anchors.fill: parent169 anchors {
170 left: parent.left
171 right: parent.right
172 }
173 //height: childrenRect.height
174
170 spacing: units.gu(1)175 spacing: units.gu(1)
171176
172 UbuntuShape {
173 width: parent.width
174 height: width
175
176 Favicon {
177 anchors.centerIn: parent
178 source: model.icon
179 }
180 }
181
182 Label {177 Label {
183 width: parent.width178 width: parent.width
184 height: units.gu(2)179 height: units.gu(2)
@@ -189,6 +184,58 @@
189184
190 text: model.title ? model.title : model.url185 text: model.title ? model.title : model.url
191 }186 }
187
188 UbuntuShape {
189 width: parent.width
190 height: units.gu(10)
191
192 // we need that to clip the background image
193 clip: true
194
195 Image {
196 source: Qt.resolvedUrl("assets/tab-artwork.png")
197 asynchronous: true
198 width: parent.height
199 height: width
200 opacity: 0.6
201 anchors {
202 right: parent.right
203 bottom: parent.bottom
204 margins: units.gu(-3)
205 }
206 }
207 Column {
208 anchors {
209 left: parent.left
210 right: parent.right
211 bottom: parent.bottom
212 margins: units.gu(1)
213 }
214
215 Favicon {
216 source: model.icon
217 }
218
219 Label {
220 anchors {
221 left: parent.left
222 right: parent.right
223 }
224 elide: Text.ElideRight
225 text: model.domain
226 fontSize: "small"
227 }
228 Label {
229 anchors {
230 left: parent.left
231 right: parent.right
232 }
233 elide: Text.ElideRight
234 text: model.title
235 fontSize: "small"
236 }
237 }
238 }
192 }239 }
193240
194 onClicked: historyEntryClicked(model.url)241 onClicked: historyEntryClicked(model.url)

Subscribers

People subscribed via source and target branches

to status/vote changes: